New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more style improvements #353

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Dandandan
Contributor

Dandandan commented Aug 16, 2015

No description provided.

@Dandandan

This comment has been minimized.

Show comment
Hide comment
@Dandandan

Dandandan Aug 18, 2015

Contributor

This runs now without issues.

Contributor

Dandandan commented Aug 18, 2015

This runs now without issues.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Aug 18, 2015

Member

I'm not a major fan of splitting up the return and setting the content. How many passes are you thinking of taking over this code? With each one I am afraid we will accidentally introduce some issue, so I comb through them all very carefully.

What is the end goal of this? How will we know when we reached that goal?

Member

evancz commented Aug 18, 2015

I'm not a major fan of splitting up the return and setting the content. How many passes are you thinking of taking over this code? With each one I am afraid we will accidentally introduce some issue, so I comb through them all very carefully.

What is the end goal of this? How will we know when we reached that goal?

@Dandandan

This comment has been minimized.

Show comment
Hide comment
@Dandandan

Dandandan Aug 19, 2015

Contributor

I share your concern about errors. Is there a way to make this easier, for example, one PR for each module or type of linting error?
I guess the end goal is to make the JS runtime easier to maintain, the linting check could even be added to the CI server when the linter passes (almost) all checks.

Contributor

Dandandan commented Aug 19, 2015

I share your concern about errors. Is there a way to make this easier, for example, one PR for each module or type of linting error?
I guess the end goal is to make the JS runtime easier to maintain, the linting check could even be added to the CI server when the linter passes (almost) all checks.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Nov 19, 2015

Member

I think this is too out of date to make sense to try to merge. I'm not sure how much more aggressive I want to be with style stuff at the moment. This stuff just makes me nervous!

Member

evancz commented Nov 19, 2015

I think this is too out of date to make sense to try to merge. I'm not sure how much more aggressive I want to be with style stuff at the moment. This stuff just makes me nervous!

@evancz evancz closed this Nov 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment