Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upmore style improvements #353
Conversation
Dandandan
added some commits
Aug 16, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This runs now without issues. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Aug 18, 2015
Member
I'm not a major fan of splitting up the return and setting the content. How many passes are you thinking of taking over this code? With each one I am afraid we will accidentally introduce some issue, so I comb through them all very carefully.
What is the end goal of this? How will we know when we reached that goal?
|
I'm not a major fan of splitting up the What is the end goal of this? How will we know when we reached that goal? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Dandandan
Aug 19, 2015
Contributor
I share your concern about errors. Is there a way to make this easier, for example, one PR for each module or type of linting error?
I guess the end goal is to make the JS runtime easier to maintain, the linting check could even be added to the CI server when the linter passes (almost) all checks.
|
I share your concern about errors. Is there a way to make this easier, for example, one PR for each module or type of linting error? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Nov 19, 2015
Member
I think this is too out of date to make sense to try to merge. I'm not sure how much more aggressive I want to be with style stuff at the moment. This stuff just makes me nervous!
|
I think this is too out of date to make sense to try to merge. I'm not sure how much more aggressive I want to be with style stuff at the moment. This stuff just makes me nervous! |
Dandandan commentedAug 16, 2015
No description provided.