New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.js needs to be imported once Elm object is no longer global under node #354

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@ajhager
Contributor

ajhager commented Aug 16, 2015

This PR should only be accepted when and if elm-lang/elm-make#43 is. That PR adds support for node, and so the elm-io-ports code should no longer be prepended to test.js, but instead require test.js as a node module.

@ajhager ajhager changed the title from test.js needs to be imported since Elm object is no longer global to test.js needs to be imported once Elm object is no longer global under node Aug 16, 2015

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Jan 19, 2016

Contributor

Is this pull request still relevant? It looks like it might be overridden by https://github.com/elm-lang/core/pull/447.

Contributor

jvoigtlaender commented Jan 19, 2016

Is this pull request still relevant? It looks like it might be overridden by https://github.com/elm-lang/core/pull/447.

@evancz evancz closed this May 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment