/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Regex.replace with AtMost #359

Merged
merged 1 commit into from Aug 19, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pisys @evancz
@pisys
Contributor

pisys commented Aug 19, 2015

passing (AtMost n) behaved actually like (AtMost n+1).
Also added some test cases.
@pisys
fix Regex.replace with AtMost 
passing (AtMost n) behaved actually like (AtMost n+1).
Also added some test cases.
4673232

evancz pushed a commit that referenced this pull request Aug 19, 2015

@process-bot
Merge pull request #359 from Pisys/fix-regex-replace 
fix Regex.replace with AtMost
b1a1c7b

@evancz evancz merged commit b1a1c7b into elm:master Aug 19, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Aug 19, 2015

Member

Nice find, thank you!
Member

evancz commented Aug 19, 2015

Nice find, thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment