New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multi-way if usage, and use = for record updates. #375

Merged
merged 1 commit into from Aug 28, 2015

Conversation

Projects
None yet
3 participants
@laszlopandy
Contributor

laszlopandy commented Aug 28, 2015

evancz pushed a commit that referenced this pull request Aug 28, 2015

Merge pull request #375 from laszlopandy/0.16-if-and-record-syntax-ch…
…anges

Remove multi-way if usage, and use = for record updates.

@evancz evancz merged commit 480c772 into elm:master Aug 28, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Aug 28, 2015

Member

Looks good to me, thank you!

Member

evancz commented Aug 28, 2015

Looks good to me, thank you!

@hughfdjackson

This comment has been minimized.

Show comment
Hide comment
@hughfdjackson

hughfdjackson Sep 5, 2015

If this change is intended for use with 0.16 is in master, should we update the elm-version in elm-package.json?

I'm failing to get master to compile on the latest version available via http://elm-lang.org/install, which I believe to be 0.15.1.

hughfdjackson commented Sep 5, 2015

If this change is intended for use with 0.16 is in master, should we update the elm-version in elm-package.json?

I'm failing to get master to compile on the latest version available via http://elm-lang.org/install, which I believe to be 0.15.1.

@laszlopandy

This comment has been minimized.

Show comment
Hide comment
@laszlopandy

laszlopandy Sep 6, 2015

Contributor

Yes. This is true. But I believed that we don't need to bump until we
publish a new version of core to the package repository.

On Sunday, September 6, 2015, Hugh FD Jackson notifications@github.com
wrote:

If this change is intended for use with 0.16 is in master, should we
update the elm-version in elm-package.json?

I'm failing to get master to compile on the latest version available via
http://elm-lang.org/install, which I believe to be 0.15.1.


Reply to this email directly or view it on GitHub
https://github.com/elm-lang/core/pull/375#issuecomment-138008751.

Contributor

laszlopandy commented Sep 6, 2015

Yes. This is true. But I believed that we don't need to bump until we
publish a new version of core to the package repository.

On Sunday, September 6, 2015, Hugh FD Jackson notifications@github.com
wrote:

If this change is intended for use with 0.16 is in master, should we
update the elm-version in elm-package.json?

I'm failing to get master to compile on the latest version available via
http://elm-lang.org/install, which I believe to be 0.15.1.


Reply to this email directly or view it on GitHub
https://github.com/elm-lang/core/pull/375#issuecomment-138008751.

@hughfdjackson

This comment has been minimized.

Show comment
Hide comment
@hughfdjackson

hughfdjackson Sep 6, 2015

:) From the perspective of someone looking to submit a first PR, it would be time-saving if the elm-package.json file reflected the current requirements of master. Took a little head-scratching to realise I was using the wrong compiler version.

I'm happy to bump the version requirements in a PR if you and @evancz (et. al.) are on board with that.

hughfdjackson commented Sep 6, 2015

:) From the perspective of someone looking to submit a first PR, it would be time-saving if the elm-package.json file reflected the current requirements of master. Took a little head-scratching to realise I was using the wrong compiler version.

I'm happy to bump the version requirements in a PR if you and @evancz (et. al.) are on board with that.

@laszlopandy

This comment has been minimized.

Show comment
Hide comment
@laszlopandy

laszlopandy Sep 6, 2015

Contributor

Makes sense to me.

On Sun, Sep 6, 2015 at 4:14 PM, Hugh FD Jackson notifications@github.com
wrote:

:) From the perspective of someone looking to submit a first PR, it would
be time-saving if the elm-package.json file reflected the current
requirements of master. Took a little head-scratching to realise I was
using the wrong compiler version.

I'm happy to bump the version requirements in a PR if you and @evancz
https://github.com/evancz (et. al.) are on board with that.


Reply to this email directly or view it on GitHub
https://github.com/elm-lang/core/pull/375#issuecomment-138089058.

Contributor

laszlopandy commented Sep 6, 2015

Makes sense to me.

On Sun, Sep 6, 2015 at 4:14 PM, Hugh FD Jackson notifications@github.com
wrote:

:) From the perspective of someone looking to submit a first PR, it would
be time-saving if the elm-package.json file reflected the current
requirements of master. Took a little head-scratching to realise I was
using the wrong compiler version.

I'm happy to bump the version requirements in a PR if you and @evancz
https://github.com/evancz (et. al.) are on board with that.


Reply to this email directly or view it on GitHub
https://github.com/elm-lang/core/pull/375#issuecomment-138089058.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment