Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove multi-way if usage, and use = for record updates. #375
Conversation
pushed a commit
that referenced
this pull request
Aug 28, 2015
evancz
merged commit 480c772
into
elm:master
Aug 28, 2015
1 check failed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Looks good to me, thank you! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hughfdjackson
Sep 5, 2015
If this change is intended for use with 0.16 is in master, should we update the elm-version in elm-package.json?
I'm failing to get master to compile on the latest version available via http://elm-lang.org/install, which I believe to be 0.15.1.
hughfdjackson
commented
Sep 5, 2015
|
If this change is intended for use with 0.16 is in master, should we update the I'm failing to get master to compile on the latest version available via http://elm-lang.org/install, which I believe to be 0.15.1. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
laszlopandy
Sep 6, 2015
Contributor
Yes. This is true. But I believed that we don't need to bump until we
publish a new version of core to the package repository.
On Sunday, September 6, 2015, Hugh FD Jackson notifications@github.com
wrote:
If this change is intended for use with 0.16 is in master, should we
update the elm-version in elm-package.json?I'm failing to get master to compile on the latest version available via
http://elm-lang.org/install, which I believe to be 0.15.1.—
Reply to this email directly or view it on GitHub
https://github.com/elm-lang/core/pull/375#issuecomment-138008751.
|
Yes. This is true. But I believed that we don't need to bump until we On Sunday, September 6, 2015, Hugh FD Jackson notifications@github.com
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hughfdjackson
Sep 6, 2015
:) From the perspective of someone looking to submit a first PR, it would be time-saving if the elm-package.json file reflected the current requirements of master. Took a little head-scratching to realise I was using the wrong compiler version.
I'm happy to bump the version requirements in a PR if you and @evancz (et. al.) are on board with that.
hughfdjackson
commented
Sep 6, 2015
|
:) From the perspective of someone looking to submit a first PR, it would be time-saving if the I'm happy to bump the version requirements in a PR if you and @evancz (et. al.) are on board with that. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
laszlopandy
Sep 6, 2015
Contributor
Makes sense to me.
On Sun, Sep 6, 2015 at 4:14 PM, Hugh FD Jackson notifications@github.com
wrote:
:) From the perspective of someone looking to submit a first PR, it would
be time-saving if the elm-package.json file reflected the current
requirements of master. Took a little head-scratching to realise I was
using the wrong compiler version.I'm happy to bump the version requirements in a PR if you and @evancz
https://github.com/evancz (et. al.) are on board with that.—
Reply to this email directly or view it on GitHub
https://github.com/elm-lang/core/pull/375#issuecomment-138089058.
|
Makes sense to me. On Sun, Sep 6, 2015 at 4:14 PM, Hugh FD Jackson notifications@github.com
|
laszlopandy commentedAug 28, 2015
@evancz
@JoeyEremondi