Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix punctuation, capitalization and spelling in documentation #384
Conversation
ianbollinger
added some commits
Sep 1, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Sep 2, 2015
Member
Can you split the spelling out into its own PR, those are all fine.
I don't think the other stuff is as clear. For example, timestamp can be used as one word. With the capitalization stuff as well, I think a lot of that varies based on usage.
Looks like Cartesian should be caps (evidence) but there are others that are less certain. Smaller PRs make it easier to figure out. If you can do a small change and say on what grounds is it "better English" then it'll be easier to change. For example, Json is a specific thing within Elm, and it handles JSON values. Not sure which is more appropriate.
|
Can you split the spelling out into its own PR, those are all fine. I don't think the other stuff is as clear. For example, timestamp can be used as one word. With the capitalization stuff as well, I think a lot of that varies based on usage. Looks like Cartesian should be caps (evidence) but there are others that are less certain. Smaller PRs make it easier to figure out. If you can do a small change and say on what grounds is it "better English" then it'll be easier to change. For example, |
ianbollinger commentedSep 1, 2015
Fix a few typos and a few other orthographic mistakes.