Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMake Array.indexedMap work for all array sizes #391
Conversation
eeue56
added some commits
Sep 4, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
evancz
Sep 5, 2015
Member
Awesome, thank you for taking a look at the Array issues!
Do I have a contributors agreement from you?
|
Awesome, thank you for taking a look at the Array issues! Do I have a contributors agreement from you? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
No problem. Yup, I sent it from enalicho@gmail.com in March I think |
pushed a commit
that referenced
this pull request
Sep 7, 2015
evancz
merged commit 05e6c22
into
elm:master
Sep 7, 2015
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build could not complete due to an error
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Thanks! |
jvoigtlaender
referenced this pull request
Sep 8, 2015
Closed
Array.indexedMap's index is 1023 maximum #271
This was referenced Oct 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
eeue56 commentedSep 4, 2015
Make Array.indexedMap work for all array sizes, instead of hitting 1024 and wrapping around, as #271 states. Added a test case from that example to ensure that the issue is fixed in future verisons