Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCorrect tree height generation for arrays of size 32^n #396
Conversation
klaftertief
referenced this pull request
Nov 21, 2015
Closed
Array.append causes runtime error on largish arrays #444
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
evancz
May 20, 2016
Member
Fix for equality is better done a different way. Overall fix for Array is better done with the Elm rewrite that is in progress.
|
Fix for equality is better done a different way. Overall fix for Array is better done with the Elm rewrite that is in progress. |
evancz
closed this
May 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
eeue56 commentedSep 8, 2015
"Fixes" #176 by making initialize and fromList generate trees of the same height for the same amount of elements. This fixes the
eqproblem by making sure that the way trees are generated (in terms of height and leafing) is consistent between the two functions.Doesn't fix the issue of equality checking on arrays with different heights yet the same elements, however.