New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve collage documentation #405

Merged
merged 2 commits into from Sep 13, 2015

Conversation

Projects
None yet
3 participants
@jvoigtlaender
Contributor

jvoigtlaender commented Sep 11, 2015

@eeue56

This comment has been minimized.

Show comment
Hide comment
@eeue56

eeue56 Sep 11, 2015

Contributor

+1

Contributor

eeue56 commented Sep 11, 2015

+1

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Sep 12, 2015

Member

It seems kind of tortured to me. How about this?

Create a collage with certain dimensions and content. It takes a width and height argument to specify dimensions, and then a list of 2D forms to describe the content.

Unlike with Elements, these 2D forms can be moved and rotated however you like. The forms are drawn in the order of the list, i.e., collage w h [a, b] will draw b on top of a.

Member

evancz commented Sep 12, 2015

It seems kind of tortured to me. How about this?

Create a collage with certain dimensions and content. It takes a width and height argument to specify dimensions, and then a list of 2D forms to describe the content.

Unlike with Elements, these 2D forms can be moved and rotated however you like. The forms are drawn in the order of the list, i.e., collage w h [a, b] will draw b on top of a.

@eeue56

This comment has been minimized.

Show comment
Hide comment
@eeue56

eeue56 Sep 12, 2015

Contributor

Better than the current and the new proposal too, +1. The example is a nice add, I think

Contributor

eeue56 commented Sep 12, 2015

Better than the current and the new proposal too, +1. The example is a nice add, I think

improved comment
... following Evan's suggestion
@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Sep 13, 2015

Contributor

I have changed the comment in an additional commit here, using Evan's suggestion.

Contributor

jvoigtlaender commented Sep 13, 2015

I have changed the comment in an additional commit here, using Evan's suggestion.

evancz pushed a commit that referenced this pull request Sep 13, 2015

@evancz evancz merged commit 6d14caa into elm:master Sep 13, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Sep 13, 2015

Member

Great, thank you!

Member

evancz commented Sep 13, 2015

Great, thank you!

@jvoigtlaender jvoigtlaender deleted the jvoigtlaender:collage branch Sep 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment