Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove collage documentation #405
Conversation
jvoigtlaender
referenced this pull request
Sep 11, 2015
Closed
Clarify which signal is discarded in Signal.merge example #392
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
+1 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Sep 12, 2015
Member
It seems kind of tortured to me. How about this?
Create a collage with certain dimensions and content. It takes a width and height argument to specify dimensions, and then a list of 2D forms to describe the content.
Unlike with
Elements, these 2D forms can be moved and rotated however you like. The forms are drawn in the order of the list, i.e.,collage w h [a, b]will drawbon top ofa.
|
It seems kind of tortured to me. How about this?
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
eeue56
Sep 12, 2015
Contributor
Better than the current and the new proposal too, +1. The example is a nice add, I think
|
Better than the current and the new proposal too, +1. The example is a nice add, I think |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Sep 13, 2015
Contributor
I have changed the comment in an additional commit here, using Evan's suggestion.
|
I have changed the comment in an additional commit here, using Evan's suggestion. |
pushed a commit
that referenced
this pull request
Sep 13, 2015
evancz
merged commit 6d14caa
into
elm:master
Sep 13, 2015
1 check failed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Great, thank you! |
jvoigtlaender commentedSep 11, 2015
Motivation for the change is here: https://github.com/elm-lang/core/pull/392#issuecomment-138097389.