/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Decode.elm #410

Merged
merged 2 commits into from Sep 21, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@simonh1000 @evancz @jvoigtlaender
@simonh1000
Contributor

simonh1000 commented Sep 17, 2015

Added example based on my pain, and max/Janis help
@simonh1000
Update Decode.elm 
Added example based on my pain, and max/Janis help
3fa9880
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Sep 17, 2015

Member

Can you make the code look like this:

extractString : Decoder String
extractString =
    tuple1 identity string

Then it should be all set!
Member

evancz commented Sep 17, 2015

Can you make the code look like this:

extractString : Decoder String
extractString =
    tuple1 identity string

Then it should be all set!
@simonh1000

This comment has been minimized.

Show comment
Hide comment
@simonh1000

simonh1000 Sep 18, 2015

Owner

I'm not very expert at pull requests, but i think you have the diff here correctly now
Owner

simonh1000 commented on 181af1e Sep 18, 2015

I'm not very expert at pull requests, but i think you have the diff here correctly now

jvoigtlaender added a commit that referenced this pull request Sep 21, 2015

@jvoigtlaender
Merge pull request #410 from simonh1000/master 
Since the second commit addresses @evancz's point about formatting of the code, I'm merging this pull request.
65c87f9

@jvoigtlaender jvoigtlaender merged commit 65c87f9 into elm:master Sep 21, 2015
1 check failed

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Sep 21, 2015

Contributor

Since the second commit addresses @evancz's point about formatting of the code, I'm merging this pull request.
Contributor

jvoigtlaender commented Sep 21, 2015

Since the second commit addresses @evancz's point about formatting of the code, I'm merging this pull request.
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Sep 21, 2015

Member

Great, thanks @simonh1000 and @jvoigtlaender!
Member

evancz commented Sep 21, 2015

Great, thanks @simonh1000 and @jvoigtlaender!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment