New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a fold function to Task. #423

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@ajevans85

ajevans85 commented Oct 11, 2015

Added a fold function to Task making mapping on left/right simpler.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Oct 11, 2015

Contributor

@ajevans85, please look at this conversation (and the CONTRIBUTING.md section linked to from there): https://github.com/elm-lang/core/pull/421#issuecomment-146932267.

If you want to suggest a Task.fold function for potential eventual inclusion in core, then start a new task-extras package, or look around for one to write a pull request for. Possibly http://package.elm-lang.org/packages/TheSeamau5/elm-task-extra/latest.

Contributor

jvoigtlaender commented Oct 11, 2015

@ajevans85, please look at this conversation (and the CONTRIBUTING.md section linked to from there): https://github.com/elm-lang/core/pull/421#issuecomment-146932267.

If you want to suggest a Task.fold function for potential eventual inclusion in core, then start a new task-extras package, or look around for one to write a pull request for. Possibly http://package.elm-lang.org/packages/TheSeamau5/elm-task-extra/latest.

@ajevans85

This comment has been minimized.

Show comment
Hide comment
@ajevans85

ajevans85 Oct 11, 2015

I have created a task-utils package, it's a pitta to import it for 1 function. It's a trivial extremely useful function, pretty common + core in other langs/tools.

Duly noted, my time will be spent elsewhere if feature requests are just shut, because ...

ajevans85 commented Oct 11, 2015

I have created a task-utils package, it's a pitta to import it for 1 function. It's a trivial extremely useful function, pretty common + core in other langs/tools.

Duly noted, my time will be spent elsewhere if feature requests are just shut, because ...

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Oct 11, 2015

Contributor

Sorry you feel offended. It's just how extensions to core are meant to be organized here. Do you prefer having your pull request kept open but ignored? (And adding cognitive burden for @evancz, because there would be a pull request open here that he "has" to ignore because it is not meant to be open according to how he wants to organize extensions of core.)

If you feel this is an inappropriate strategy, maybe start a discussion on the mailing list?

Contributor

jvoigtlaender commented Oct 11, 2015

Sorry you feel offended. It's just how extensions to core are meant to be organized here. Do you prefer having your pull request kept open but ignored? (And adding cognitive burden for @evancz, because there would be a pull request open here that he "has" to ignore because it is not meant to be open according to how he wants to organize extensions of core.)

If you feel this is an inappropriate strategy, maybe start a discussion on the mailing list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment