New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for 0.16 #446

Closed
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@klaftertief

klaftertief commented Nov 23, 2015

I took the liberty to update the tests for 0.16, hope this is ok. This includes

  • updated dependencies
  • updated run-test.sh to use elm-console/elm-io.sh
  • removed Basics.otherwise test.

I disabled the letQualified test in CodeGen.elm because it did not compile and I din't know exactly how to fix it.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Jan 19, 2016

Contributor

@klaftertief, do you know why there is still a build failure with your PR? @deadfoxygrandpa did similar work later in #447. Probably only one of the two should be kept open. If you are still interested in this, maybe you could take a look at his PR and see whether he covers all you did? And if not, bring it up over there so that we can end up with a single PR that hopefully addresses the test build issue once and for all?

Contributor

jvoigtlaender commented Jan 19, 2016

@klaftertief, do you know why there is still a build failure with your PR? @deadfoxygrandpa did similar work later in #447. Probably only one of the two should be kept open. If you are still interested in this, maybe you could take a look at his PR and see whether he covers all you did? And if not, bring it up over there so that we can end up with a single PR that hopefully addresses the test build issue once and for all?

@klaftertief

This comment has been minimized.

Show comment
Hide comment
@klaftertief

klaftertief Jan 19, 2016

The build failure is because of cabal hell. This is why @deadfoxygrandpa switched to the npm installer.

The other changes, updating the test runner and the tests itself, are basically the same. So I'm closing this pull request in favour of #447 in the assumption that using the npm installer is the way to go.

klaftertief commented Jan 19, 2016

The build failure is because of cabal hell. This is why @deadfoxygrandpa switched to the npm installer.

The other changes, updating the test runner and the tests itself, are basically the same. So I'm closing this pull request in favour of #447 in the assumption that using the npm installer is the way to go.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Jan 19, 2016

Contributor

Good to know. Thanks!

Contributor

jvoigtlaender commented Jan 19, 2016

Good to know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment