Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate tests for 0.16 #446
Conversation
klaftertief
added some commits
Nov 23, 2015
jvoigtlaender
referenced this pull request
Jan 18, 2016
Closed
Regex.replace does not set the index accurately #483
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Jan 19, 2016
Contributor
@klaftertief, do you know why there is still a build failure with your PR? @deadfoxygrandpa did similar work later in #447. Probably only one of the two should be kept open. If you are still interested in this, maybe you could take a look at his PR and see whether he covers all you did? And if not, bring it up over there so that we can end up with a single PR that hopefully addresses the test build issue once and for all?
|
@klaftertief, do you know why there is still a build failure with your PR? @deadfoxygrandpa did similar work later in #447. Probably only one of the two should be kept open. If you are still interested in this, maybe you could take a look at his PR and see whether he covers all you did? And if not, bring it up over there so that we can end up with a single PR that hopefully addresses the test build issue once and for all? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
klaftertief
Jan 19, 2016
The build failure is because of cabal hell. This is why @deadfoxygrandpa switched to the npm installer.
The other changes, updating the test runner and the tests itself, are basically the same. So I'm closing this pull request in favour of #447 in the assumption that using the npm installer is the way to go.
klaftertief
commented
Jan 19, 2016
|
The build failure is because of cabal hell. This is why @deadfoxygrandpa switched to the npm installer. The other changes, updating the test runner and the tests itself, are basically the same. So I'm closing this pull request in favour of #447 in the assumption that using the npm installer is the way to go. |
klaftertief
closed this
Jan 19, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Good to know. Thanks! |
klaftertief commentedNov 23, 2015
I took the liberty to update the tests for 0.16, hope this is ok. This includes
run-test.shto useelm-console/elm-io.shBasics.otherwisetest.I disabled the
letQualifiedtest inCodeGen.elmbecause it did not compile and I din't know exactly how to fix it.