Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upHave toString display Date values in ISO format #481
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mietek
commented
Jan 18, 2016
|
This is a duplicate of https://github.com/elm-lang/core/pull/442. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Jan 19, 2016
Contributor
So, can this pull request be closed? I notice that while it addresses the same issue as #442, it does propose a slightly different code change. Is the one here better than the other one? Why?
|
So, can this pull request be closed? I notice that while it addresses the same issue as #442, it does propose a slightly different code change. Is the one here better than the other one? Why? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
fredcy
Jan 19, 2016
Contributor
I didn't notice https://github.com/elm-lang/core/pull/442 before opening this request. I'm OK with closing this request as a duplicate.
|
I didn't notice https://github.com/elm-lang/core/pull/442 before opening this request. I'm OK with closing this request as a duplicate. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Jan 19, 2016
Contributor
Okay, I'm closing it, but copying your example program over to the other discussion, because it could be useful for testing over there as well.
|
Okay, I'm closing it, but copying your example program over to the other discussion, because it could be useful for testing over there as well. |
fredcy commentedJan 14, 2016
The core
toStringfunction returns the String value "{}" for allDatevalues. That makes it hard to display Date values for debugging. This patch extendstoStringto displayDatevalues in ISO format like "<date 2016-01-14T15:06:41.393Z>".Here is a test program that I've been using. On regular intervals it displays the value of Time.every (to show liveness) and the corresponding Date value: