Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded vimKeys as another movement signal #492
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Jan 25, 2016
Contributor
Please read this: https://github.com/elm-lang/core/blob/master/CONTRIBUTING.md#adding-new-functions.
There doesn't seem to be a keyboard-extras package around yet, but you could start one.
Also, dropMap is just a combination of Signal.dropRepeats and Signal.map, so no real hindrance to a client programmer, and Directions, being a type alias rather than a type, is also not really hidden away. A client pogrammer can readily use the type { up : KeyCode, down : KeyCode, left : KeyCode, right : KeyCode }. So the only real annoyance for a client programmer who wants vimKeys is that they need to reimplement the toXY function.
So a viable course of action would be to propose to export that function (toXY) for client use. That would be a separate issue you may want to open.
The current issue, about adding a completely new function, I am closing in accordance with the policy about new functions linked to above.
|
Please read this: https://github.com/elm-lang/core/blob/master/CONTRIBUTING.md#adding-new-functions. There doesn't seem to be a Also, So a viable course of action would be to propose to export that function ( The current issue, about adding a completely new function, I am closing in accordance with the policy about new functions linked to above. |
jvoigtlaender
closed this
Jan 25, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Jan 25, 2016
Contributor
BTW, there was once a more generic function capturing "arrow behavior": http://package.elm-lang.org/packages/elm-lang/core/1.0.0/Keyboard#directions
It was removed when going to core version 2.0.0. I don't know what decision process led to that.
|
BTW, there was once a more generic function capturing "arrow behavior": http://package.elm-lang.org/packages/elm-lang/core/1.0.0/Keyboard#directions It was removed when going to |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
meditans
commented
Jan 25, 2016
|
I see, thanks for the useful explanations :) |
meditans commentedJan 25, 2016
Otherwise, if one wants to implement vimKeys by its own, it has to rewrite in his code
dropMap,toXY, andtype alias Directions, which are not exported.