/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsubscribing from ports #494

Closed
wants to merge 2 commits into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@RGBboy @dfreeman @evancz
@RGBboy

RGBboy commented Jan 29, 2016

Hey, so I found a weeeee bug in the unsubscription of a port. It would only pop the last added subscription instead of the one you are actually unsubscribing. Let me know if there is anything else that needs to be done to get this merged.
@dfreeman

This comment has been minimized.

Show comment
Hide comment
@dfreeman

dfreeman Mar 2, 2016

I think this still behaves badly in the case where it's given a handler that isn't subscribed, since array.splice(-1, 1) removes the last element of array.

dfreeman commented Mar 2, 2016

I think this still behaves badly in the case where it's given a handler that isn't subscribed, since array.splice(-1, 1) removes the last element of array.
@RGBboy

This comment has been minimized.

Show comment
Hide comment
@RGBboy

RGBboy Mar 2, 2016

@dfreeman nice catch. Fixed in db7efc5.

RGBboy commented Mar 2, 2016

@dfreeman nice catch. Fixed in db7efc5.
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Apr 28, 2016

Member

Thanks! It works this way in the upcoming version of things.
Member

evancz commented Apr 28, 2016

Thanks! It works this way in the upcoming version of things.

@evancz evancz closed this Apr 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment