Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSet style options of croppedImage before onload #499
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
evancz
May 11, 2016
Member
Sorry for the slow reply. It has been busy times. All the Graphics.* modules have moved to evancz/elm-graphics so it makes sense to retarget stuff like this.
|
Sorry for the slow reply. It has been busy times. All the |
evancz
closed this
May 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
erich-9 commentedFeb 6, 2016
The current implementation of Graphics.Element.croppedImage loads the image from its source. Only afterwards, when the onload event is triggered, the style options are set.
In this commit, I set the options not depending on the image's natural size as early as possible (namely, marginLeft and marginTop).
This reduces unpleasant flickering, at least as long as the image is not scaled. Compare with #456.