Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd keyCode signal for keydown events #500
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Feb 8, 2016
Contributor
You'd have to add "downs" to the @docs section as well, or the package won't be publishable. Also, https://github.com/elm-lang/core/pull/463, though probably they don't interfere.
|
You'd have to add "downs" to the @docs section as well, or the package won't be publishable. Also, https://github.com/elm-lang/core/pull/463, though probably they don't interfere. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
justinwoo
Feb 8, 2016
Ah, thanks.
I think the diff should go through fine with no conflicts, but I could rebase if that one goes in first.
justinwoo
commented
Feb 8, 2016
|
Ah, thanks. I think the diff should go through fine with no conflicts, but I could rebase if that one goes in first. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
With 0.17 this is no longer the responsibility of core. |
justinwoo commentedFeb 8, 2016
This commit adds a signal for
keyCodesfrom thekeydownevent to the exports.Currently,
pressesare exposed, but they don't capture keyboard arrow key inputs. This makes the natural "key-repeat"keydownevents unusable unless one either sets up a port or writes their own Native function, but that would be wasteful since thekeydownevent is already listened to in the core Keyboard module.