New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyCode signal for keydown events #500

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@justinwoo

justinwoo commented Feb 8, 2016

This commit adds a signal for keyCodes from the keydown event to the exports.

Currently, presses are exposed, but they don't capture keyboard arrow key inputs. This makes the natural "key-repeat" keydown events unusable unless one either sets up a port or writes their own Native function, but that would be wasteful since the keydown event is already listened to in the core Keyboard module.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Feb 8, 2016

Contributor

You'd have to add "downs" to the @docs section as well, or the package won't be publishable. Also, https://github.com/elm-lang/core/pull/463, though probably they don't interfere.

Contributor

jvoigtlaender commented Feb 8, 2016

You'd have to add "downs" to the @docs section as well, or the package won't be publishable. Also, https://github.com/elm-lang/core/pull/463, though probably they don't interfere.

@justinwoo

This comment has been minimized.

Show comment
Hide comment
@justinwoo

justinwoo Feb 8, 2016

Ah, thanks.

I think the diff should go through fine with no conflicts, but I could rebase if that one goes in first.

justinwoo commented Feb 8, 2016

Ah, thanks.

I think the diff should go through fine with no conflicts, but I could rebase if that one goes in first.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz May 10, 2016

Member

With 0.17 this is no longer the responsibility of core.

Member

evancz commented May 10, 2016

With 0.17 this is no longer the responsibility of core.

@evancz evancz closed this May 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment