Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDebug.log: remove dead code, always use console.log #507
Conversation
rtfeldman
added
the
bug
label
Apr 21, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Jul 8, 2017
Member
I don't know if this changed since the code was changed away from just calling console.log directly in the first place. Maybe it has. I am changing how logging works a bit in 0.19 so I will review it then and verify what is necessary.
Thank you for bringing this to my attention!
|
I don't know if this changed since the code was changed away from just calling Thank you for bringing this to my attention! |
evancz
closed this
Jul 8, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jonathanperret
Jul 9, 2017
Contributor
You did remove the problematic code in f4976fb so this PR is indeed no longer useful.
|
You did remove the problematic code in f4976fb so this PR is indeed no longer useful. |
jonathanperret commentedFeb 25, 2016
The code to use
process.stdout.writethat was introduced in elm/compiler@142c2c likely never worked: thevar x = x || {}trick only ever works for variables already defined in the same scope as thevarstatement, whichprocessdefinitely is not under Node.Additionally,
console.logworks just fine in Node, and adds a newline whereprocess.stdout.writedoes not (which would have been immediately obvious if that code path had ever been taken).