Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove dashOffset field from LineStyle type in Graphics.Collage #535
Conversation
jvoigtlaender
referenced this pull request
Mar 23, 2016
Closed
LineStyle.dashOffset doesn't have any effect (is ignored in implementation) #534
jvoigtlaender
referenced this pull request
Apr 18, 2016
Closed
Change type of LineStyle.dashing from "List Int" to "List Float" #562
jvoigtlaender
closed this
May 8, 2016
jvoigtlaender
deleted the
jvoigtlaender-patch-5
branch
May 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jvoigtlaender commentedMar 23, 2016
The field has currently no effect at all, it is ignored in the complete code base (neither
outlined, nortraced, noroutlinedTextrespect it). So it would be better to not be there.In the current situation, with the field being there, it not having an effect is clearly a bug. See https://github.com/elm-lang/core/issues/534.