Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCorrections for Task documentation concerning use of == #557
Conversation
halfzebra
referenced this pull request
Apr 10, 2016
Closed
Documentation suggests that `==` works on tasks, but it doesn't #502
jvoigtlaender
changed the title from
Corrections for Task documentation
to
Corrections for Task documentation concerning use of ==
Apr 11, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
jvoigtlaender
Apr 11, 2016
Contributor
An example of where already the current docs use -- instead of == is the documentation of onError, which has these lines:
fail "file not found" `onError` (\msg -> succeed 42) -- succeed 42
succeed 9 `onError` (\msg -> succeed 42) -- succeed 9This PR fixes the other examples on that doc page to be given in the same style (and thus avoids confusing uses of == on tasks).
|
An example of where already the current docs use -- instead of == is the documentation of fail "file not found" `onError` (\msg -> succeed 42) -- succeed 42
succeed 9 `onError` (\msg -> succeed 42) -- succeed 9This PR fixes the other examples on that doc page to be given in the same style (and thus avoids confusing uses of |
evancz
merged commit 2226d1b
into
elm:master
Apr 28, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Thanks, makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
halfzebra commentedApr 10, 2016
Corrections for Task module documentation.
The relevant issue #502 was:
I have replaced all equality operators == with comment -- to standardize the style of the docs(before it had both in different places)
Also I have added a note, that == shoudn't be used with Tasks.