Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upChange type of LineStyle.dashing from "List Int" to "List Float" #562
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Apr 18, 2016
Contributor
Why would you not also change the type of LineStyle.dashOffset, then? (ignoring for the moment that it is currently defunct, see https://github.com/elm-lang/core/pull/535)
Certainly if dashing is a List Float, then dashOffset should be a Float.
|
Why would you not also change the type of Certainly if |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pisys
Apr 18, 2016
Contributor
Yes, I forgot to mention that that change should account for dashOffset too, of course.
|
Yes, I forgot to mention that that change should account for dashOffset too, of course. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
May 10, 2016
Member
Sorry for the slow reply. It has been busy times. All the Graphics.* modules have moved to evancz/elm-graphics so it makes sense to retarget stuff like this.
|
Sorry for the slow reply. It has been busy times. All the |
pisys commentedApr 18, 2016
Why?
The background I'm making this PR on: I use to define shapes with relative coordinates and dimensions and finally scale the whole group of shapes to the actual size of the canvas. With LineStyle.dashing being of type
List Int, this is not possible.