fixes error on documentation for filterMap

[rebelwarrior]

This line filterMap String.toInt ["3", "4.0", "5", "hats"] == [3,5] would not work since toInt doesn't produce a Maybe but a Result.

[jvoigtlaender]

Two comments:

1. Don't do the List. prefix for filterMap there. I think this is done nowhere in the documentation, that documentation for function f is prefixed by its module name inside that defining module.
2. A similar fix in the documentation for Signal.filterMap should probably be done in the same go.

[jvoigtlaender]

Two comments:

1. Don't do the List. prefix for filterMap there. I think this is done nowhere in the documentation, that documentation for function f is prefixed by its module name inside that defining module.
2. A similar fix in the documentation for Signal.filterMap should probably be done in the same go.

[rebelwarrior]

Oh shoot I thought I took the prefix out. That was an oversight. (Copy paste from command line)

I'll do another pull request tonight.

Sent from my mobile.

On Apr 27, 2016, at 2:47 AM, Janis Voigtländer notifications@github.com wrote:

Two comments:

Don't do the List. prefix for filterMap there. I think this is done nowhere in the documentation, that documentation for function f is prefixed by its module name inside that defining module.
A similar fix in the documentation for Signal.filterMap should probably be done in the same go.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[rebelwarrior]

Oh shoot I thought I took the prefix out. That was an oversight. (Copy paste from command line)

I'll do another pull request tonight.

Sent from my mobile.

On Apr 27, 2016, at 2:47 AM, Janis Voigtländer notifications@github.com wrote:

Two comments:

Don't do the List. prefix for filterMap there. I think this is done nowhere in the documentation, that documentation for function f is prefixed by its module name inside that defining module.
A similar fix in the documentation for Signal.filterMap should probably be done in the same go.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[jvoigtlaender]

Cool. Actually, you can keep it simple, I think. Just remove the prefix and squash the commits. I just realized that making a corresponding change to the documentation of Signal.filterMap is not really necessary, with the changes to core that are on the horizon.

[jvoigtlaender]

Cool. Actually, you can keep it simple, I think. Just remove the prefix and squash the commits. I just realized that making a corresponding change to the documentation of Signal.filterMap is not really necessary, with the changes to core that are on the horizon.

[jvoigtlaender]

Thanks for opening the other PR. Closing this one here in favour of the other one.

[jvoigtlaender]

Thanks for opening the other PR. Closing this one here in favour of the other one.

[rebelwarrior]

I could not find it to close it. Thought you'd closed it already. :)

Sent from my mobile.

On Apr 27, 2016, at 1:57 PM, Janis Voigtländer notifications@github.com wrote:

Thanks for opening the other PR. Closing this one here in favour of the other one.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[rebelwarrior]

I could not find it to close it. Thought you'd closed it already. :)

Sent from my mobile.

On Apr 27, 2016, at 1:57 PM, Janis Voigtländer notifications@github.com wrote:

Thanks for opening the other PR. Closing this one here in favour of the other one.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub