New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap bitwise like the rest of native #570

Merged
merged 1 commit into from Apr 27, 2016

Conversation

Projects
None yet
2 participants
@eeue56
Contributor

eeue56 commented Apr 27, 2016

Problem:

Having a bare return statement without a wrapping breaks a lot of build tools, because they try and load things as JS and get things wrong. These things are important to watch for build-tools, since that's how they know when packages have been upgraded and to re-run elm-make.

screen shot 2016-04-27 at 13 00 20

Solution:

Wrap the return statement with a function like the rest.

@evancz this is fairly important to be fixed before non-alpha release

@eeue56 eeue56 referenced this pull request Apr 27, 2016

Merged

update for 0.17 #13

@evancz evancz merged commit dba973d into elm:dev Apr 27, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Apr 27, 2016

Member

Thanks. I can tell it is important ;) If someone imports Bitwise their Elm code would just not work at all.

Member

evancz commented Apr 27, 2016

Thanks. I can tell it is important ;) If someone imports Bitwise their Elm code would just not work at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment