Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upWrap bitwise like the rest of native #570
Conversation
evancz
merged commit dba973d
into
elm:dev
Apr 27, 2016
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build could not complete due to an error
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
evancz
Apr 27, 2016
Member
Thanks. I can tell it is important ;) If someone imports Bitwise their Elm code would just not work at all.
|
Thanks. I can tell it is important ;) If someone imports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
eeue56 commentedApr 27, 2016
Problem:
Having a bare
returnstatement without a wrapping breaks a lot of build tools, because they try and load things as JS and get things wrong. These things are important to watch for build-tools, since that's how they know when packages have been upgraded and to re-run elm-make.Solution:
Wrap the return statement with a function like the rest.
@evancz this is fairly important to be fixed before non-alpha release