New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test suite to work with 0.17 #579

Merged
merged 6 commits into from May 11, 2016

Conversation

Projects
None yet
2 participants
@eeue56
Contributor

eeue56 commented Apr 29, 2016

Problem:

  • core tests didn't work with 0.17

Solution:

  • Use updated elm-test
  • Update syntax
  • to run now, you just need to do ./set-up-tests.sh and it will take care of everything
  • Update travis (currently failing due to Json.Decode possible bug, see other notes)

Other notes:

  • No longer need to clone elm-console or anything else! No need for any external native packages
  • Every test passed, except for decoding large ints in Json.Decode. Based on this commit, it might just be that the tests are outdated, and should actually be failing for ints like 1801439850948 anyway. Updating the tests to expect decoding to fail means the whole test suite passes.
  • When 0.17 is released, I'll make a PR to use 0.17 final binary and update elm-test package to be elm-community/elm-test

@eeue56 eeue56 changed the title from Problem: to Update test suite to work with 0.17 Apr 29, 2016

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz May 11, 2016

Member

Awesome, thank you!

Member

evancz commented May 11, 2016

Awesome, thank you!

@evancz evancz merged commit b9dbc56 into elm:master May 11, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@eeue56 eeue56 referenced this pull request May 13, 2016

Merged

Update for 0.17. Resolves #6. #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment