/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept large integer values in JSON decoders #586

Merged
merged 1 commit into from May 11, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@spektroskop @liamcurry @evancz
@spektroskop
Contributor

spektroskop commented May 2, 2016

In 0.17, decoding integer values larger than 2147483647 from JSON fails:

UnexpectedPayload "Expecting an Int at _.foo.bar but instead got: 2934520482"

This change seems to fix the issue. It's basically reverting to the logic used in 0.16 with the return values changed to match the API used in 0.17.
@liamcurry

This comment has been minimized.

Show comment
Hide comment
@liamcurry

liamcurry May 10, 2016

Here's the commit where this was changed FYI

liamcurry commented May 10, 2016

Here's the commit where this was changed FYI
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz May 11, 2016

Member

I guess I failed at De Morgan's Law. Thanks for the fix!
Member

evancz commented May 11, 2016

I guess I failed at De Morgan's Law. Thanks for the fix!

@evancz evancz closed this May 11, 2016

@evancz evancz reopened this May 11, 2016

@evancz evancz merged commit 85f5e4d into elm:master May 11, 2016
1 check was pending

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@jvoigtlaender jvoigtlaender referenced this pull request May 23, 2016

Closed

json parse integer 64bit timestamp #622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment