/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module embedding #589

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@klaftertief @evancz
@klaftertief

klaftertief commented May 9, 2016

Renames embed functions to prevent infinite recursion when calling embed()
@klaftertief
Fix module embedding 
Renames embed functions to prevent infinite recursion when calling `embed()`
3263155

@evancz evancz closed this in 4d155df May 9, 2016

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz May 9, 2016

Member

Thanks! I did it a different way, but thanks for finding this and explaining what was wrong. The point of those names was so you get a nicer stack trace in JS, so it doesn't make sense to change them.
Member

evancz commented May 9, 2016

Thanks! I did it a different way, but thanks for finding this and explaining what was wrong. The point of those names was so you get a nicer stack trace in JS, so it doesn't make sense to change them.
@klaftertief

This comment has been minimized.

Show comment
Hide comment
@klaftertief

klaftertief May 9, 2016

Thanks for the quick fix. And I also prefer your changes.

klaftertief commented May 9, 2016

Thanks for the quick fix. And I also prefer your changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment