Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix dates always being equal #596
Conversation
tesk9
added some commits
May 12, 2016
eeue56
reviewed
May 12, 2016
src/Native/Utils.js
| if (x instanceof Date && y instanceof Date) | ||
| { | ||
| if (x.valueOf() !== y.valueOf()) | ||
| { return false; } |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
eeue56
May 12, 2016
Contributor
Evan's preferred format is to stick the return on the next line too, then align the closing bracket with the first
eeue56
May 12, 2016
Contributor
Evan's preferred format is to stick the return on the next line too, then align the closing bracket with the first
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
eeue56
May 12, 2016
Contributor
also for what it's worth, I think you should probably just do return x.valueOf() === y.valueOf() since there's no point doing anything else.
eeue56
May 12, 2016
Contributor
also for what it's worth, I think you should probably just do return x.valueOf() === y.valueOf() since there's no point doing anything else.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tesk9
May 13, 2016
I added a test for the tempting return x.valueOf === thing. It's in a while statement, so returning true could lead to false equality for complex structures.
tesk9
May 13, 2016
I added a test for the tempting return x.valueOf === thing. It's in a while statement, so returning true could lead to false equality for complex structures.
tesk9
added some commits
May 12, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
|
tesk9 commentedMay 12, 2016
Fixes #468
Adds tests for Date around equality.