/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Json.Decode message in case of failures #604

Closed
wants to merge 3 commits into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mariosangiorgio @evancz
@mariosangiorgio
Contributor

mariosangiorgio commented May 15, 2016

JSon.Decode.fail let the user specify an error message, which is very useful to figure out what's going on.

With this pull request the error is not ignored anymore and it can be displayed.

Before the error message was

FAILED. I ran into a `fail` decoder

With the new code it also reports the reason:

FAILED. I ran into a `fail` ($REASON) decoder

mariosangiorgio added some commits May 15, 2016

@mariosangiorgio
Improved Json.Decode message in case of failures
Unverified
The key that signed this is expired.
GPG key ID: CEB8F5705E9F624E Learn about signing commits
bafe869
@mariosangiorgio
Added example to Json.Decode.andThen following question on elm-discuss
Unverified
The key that signed this is expired.
GPG key ID: CEB8F5705E9F624E Learn about signing commits
928b53b
@mariosangiorgio
Merged changes from upstream
Unverified
The key that signed this is expired.
GPG key ID: CEB8F5705E9F624E Learn about signing commits
ab36c78
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz May 19, 2016

Member

This should be brought in now. Thanks!
Member

evancz commented May 19, 2016

This should be brought in now. Thanks!

@evancz evancz closed this May 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment