Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd test case for #602 pull request fix. #605
Conversation
rluiten
and others
added some commits
May 15, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
eeue56
May 15, 2016
Contributor
@lukewestby @rluiten could one of you please update this PR with context from #602 ?
|
@lukewestby @rluiten could one of you please update this PR with context from #602 ? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
lukewestby
May 15, 2016
Member
@eeue56 sure!
The primary occurrence of this issue is described in this thread from elm-dev. One of the tests in @rluiten's trie package is attempting to decode key-value pairs on something that is not an object. Instead of resulting in Err as expect, it's throwing a runtime error because the err function used on https://github.com/elm-lang/core/blob/master/src/Native/Json.js#L409 does not exist and should be badPrimitive instead. As of Sun May 15 2016 10:58:49 GMT-0500 (CDT) this PR is still waiting on rluiten#1 and will include both the fix and the test case covering this branch of runHelp in Native.Json once merged.
|
@eeue56 sure! The primary occurrence of this issue is described in this thread from elm-dev. One of the tests in @rluiten's |
rluiten
added some commits
May 15, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
eeue56
May 17, 2016
Contributor
@evancz ping (this is fairly important)
tl;dr -
Problem
- dict decoding can cause a runtime error
Solution
errshould bebadPrimitive, this renames that- add a test case to make sure dict decoding is more tested
|
@evancz ping (this is fairly important) tl;dr - Problem
Solution
|
rluiten commentedMay 15, 2016
No description provided.