Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upA quick fix on https://github.com/elm-lang/core/issues/618 #619
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This is not how this issue will be fixed. |
jvoigtlaender
closed this
May 21, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
May 21, 2016
Contributor
Well, let's leave that decision to Evan, actually. Maybe he wants to fix the Json decoder special case that way for the moment. But the general solution is of course to fix the compiler issue.
|
Well, let's leave that decision to Evan, actually. Maybe he wants to fix the Json decoder special case that way for the moment. But the general solution is of course to fix the compiler issue. |
jvoigtlaender
reopened this
May 21, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ivanceras
May 22, 2016
I should have used the word workaround. This is just a workaround, which solves the issue while a proper fix has not yet landed. This lets me continue work on my projects.
ivanceras
commented
May 22, 2016
|
I should have used the word |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
May 22, 2016
Contributor
Yes, I realize it's just a stop-gap measure for a specific case. Which is why I don't believe Evan is going to want to merge it into core.
As I commented in the issue itself, there are existing workarounds, without changing core. Mainly using a lazy-function.
|
Yes, I realize it's just a stop-gap measure for a specific case. Which is why I don't believe Evan is going to want to merge it into core. As I commented in the issue itself, there are existing workarounds, without changing core. Mainly using a lazy-function. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Sep 22, 2016
Member
It looks like this just makes the crash happen later. It will still definitely happen though as far as I can tell. Better to actually fix things.
|
It looks like this just makes the crash happen later. It will still definitely happen though as far as I can tell. Better to actually fix things. |
ivanceras commentedMay 21, 2016
•
edited
Edited 1 time
-
ivanceras
edited May 21, 2016 (most recent)
Making sure
decoderandresultis notundefinedThis change is