Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upTrivial (hopefully) fixes to docs #62
Conversation
mgold
added some commits
Dec 22, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Psst, any pre-0.14.1 attention? It's fast. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Jan 7, 2015
Member
I didn't really like the Signal changes, and I didn't know how to resolve that. That's why I did not merge earlier. Otherwise it is good.
|
I didn't really like the Signal changes, and I didn't know how to resolve that. That's why I did not merge earlier. Otherwise it is good. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mgold
Jan 8, 2015
Contributor
I assume you mean the docs changes? Fine, reverted. If there's anything else, please just say so. Or merge and then fix yourself.
|
I assume you mean the docs changes? Fine, reverted. If there's anything else, please just say so. Or merge and then fix yourself. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Cool, thank you! |
pushed a commit
that referenced
this pull request
Jan 8, 2015
evancz
merged commit b37f58f
into
elm:master
Jan 8, 2015
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Jan 8, 2015
Member
As of yesterday, there are some guidelines for contributions on this repo. In the future, please make PRs minimal. If it can reasonably be split up, it should be split up.
|
As of yesterday, there are some guidelines for contributions on this repo. In the future, please make PRs minimal. If it can reasonably be split up, it should be split up. |
mgold commentedDec 22, 2014
This PR is meant to be very easy to merge. If there's something you don't like, let me know and I'll back it out. I added a few clarifying notes that shouldn't be too controversial and removed a reference to the nonexistent
(?)operator. Dict and Set equality is unreliable as a point of fact and we should document it.Again, let me know if any particular change is troublesome. Thanks.