New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial (hopefully) fixes to docs #62

Merged
merged 3 commits into from Jan 8, 2015

Conversation

Projects
None yet
2 participants
@mgold
Contributor

mgold commented Dec 22, 2014

This PR is meant to be very easy to merge. If there's something you don't like, let me know and I'll back it out. I added a few clarifying notes that shouldn't be too controversial and removed a reference to the nonexistent (?) operator. Dict and Set equality is unreliable as a point of fact and we should document it.

import Set as S
import Text (asText)

main = asText <| S.fromList [1,2] == S.fromList [2,1]

Again, let me know if any particular change is troublesome. Thanks.

@mgold

This comment has been minimized.

Show comment
Hide comment
@mgold

mgold Jan 6, 2015

Contributor

Psst, any pre-0.14.1 attention? It's fast.

Contributor

mgold commented Jan 6, 2015

Psst, any pre-0.14.1 attention? It's fast.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jan 7, 2015

Member

I didn't really like the Signal changes, and I didn't know how to resolve that. That's why I did not merge earlier. Otherwise it is good.

Member

evancz commented Jan 7, 2015

I didn't really like the Signal changes, and I didn't know how to resolve that. That's why I did not merge earlier. Otherwise it is good.

@mgold

This comment has been minimized.

Show comment
Hide comment
@mgold

mgold Jan 8, 2015

Contributor

I assume you mean the docs changes? Fine, reverted. If there's anything else, please just say so. Or merge and then fix yourself.

Contributor

mgold commented Jan 8, 2015

I assume you mean the docs changes? Fine, reverted. If there's anything else, please just say so. Or merge and then fix yourself.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jan 8, 2015

Member

Cool, thank you!

Member

evancz commented Jan 8, 2015

Cool, thank you!

evancz pushed a commit that referenced this pull request Jan 8, 2015

Merge pull request #62 from mgold/docs-typos
Trivial (hopefully) fixes to docs

@evancz evancz merged commit b37f58f into elm:master Jan 8, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jan 8, 2015

Member

As of yesterday, there are some guidelines for contributions on this repo. In the future, please make PRs minimal. If it can reasonably be split up, it should be split up.

Member

evancz commented Jan 8, 2015

As of yesterday, there are some guidelines for contributions on this repo. In the future, please make PRs minimal. If it can reasonably be split up, it should be split up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment