Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd tests for equality, concerning records #655
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
process-bot
Jul 2, 2016
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Jul 2, 2016
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
jvoigtlaender
changed the title from
Add tests for equality, concerning record constructors
to
Add tests for equality, concerning records
Jul 2, 2016
jvoigtlaender
referenced this pull request
Jul 12, 2016
Closed
`(==)` does not work correctly on records with field named `ctor` #652
evancz
merged commit cc7a7eb
into
elm:master
Jul 12, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Cool, thanks! |
jvoigtlaender
deleted the
jvoigtlaender:constr-eq-tests
branch
Jul 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jvoigtlaender commentedJul 2, 2016
The purpose of these is to expose, to testing, any special case treatment surrounding the record field name
ctor. See https://github.com/elm-lang/core/issues/652, which observed a bug in this.