Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd tests for toString, concerning records #656
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Jul 2, 2016
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Jul 2, 2016
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
lukewestby
added
the
testing
label
Sep 12, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rtfeldman
Dec 5, 2016
Member
@jvoigtlaender thanks for this! If you wouldn't mind rebasing to resolve the merge conflict, I'd love to merge this!
|
@jvoigtlaender thanks for this! If you wouldn't mind rebasing to resolve the merge conflict, I'd love to merge this! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@rtfeldman, rebased it. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Lovely, thank you @jvoigtlaender! |
jvoigtlaender commentedJul 2, 2016
The purpose of these is to expose, to testing, any special case treatment surrounding the record field name
ctor. See https://github.com/elm-lang/core/issues/654, which observed a bug in this.