New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dead code for equality() in Native/Json #662

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@jvoigtlaender
Contributor

jvoigtlaender commented Jul 14, 2016

I noticed that this appears to be dead code. If it is indeed some leftover not needed anymore, it could be removed. If instead it is needed in some way I did not spot, sorry for the disturbance.

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Jul 14, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Jul 14, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@rgrempel

This comment has been minimized.

Show comment
Hide comment
Contributor

rgrempel commented Jul 14, 2016

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Jul 14, 2016

Contributor

Ah, good to know. I was only thinking about core internally. My bad.

Contributor

jvoigtlaender commented Jul 14, 2016

Ah, good to know. I was only thinking about core internally. My bad.

@jvoigtlaender jvoigtlaender deleted the jvoigtlaender:dead-code branch Jul 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment