Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRemoved dead code for equality() in Native/Json #662
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Jul 14, 2016
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Jul 14, 2016
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rgrempel
Jul 14, 2016
Contributor
I believe that the code may be used here:
https://github.com/elm-lang/virtual-dom/blob/master/src/Native/VirtualDom.js#L252-L262
|
I believe that the code may be used here: https://github.com/elm-lang/virtual-dom/blob/master/src/Native/VirtualDom.js#L252-L262 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Jul 14, 2016
Contributor
Ah, good to know. I was only thinking about core internally. My bad.
|
Ah, good to know. I was only thinking about |
jvoigtlaender commentedJul 14, 2016
I noticed that this appears to be dead code. If it is indeed some leftover not needed anymore, it could be removed. If instead it is needed in some way I did not spot, sorry for the disturbance.