New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example for flip #672

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@willnwhite

willnwhite commented Jul 21, 2016

No description provided.

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Jul 21, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Jul 21, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Jul 22, 2016

Contributor

Criticism of the example:

The name divideBy ist not appropriate for a function defined as:

f a b = a / b

It would be appropriate for a function defined as:

f a b = b / a
Contributor

jvoigtlaender commented Jul 22, 2016

Criticism of the example:

The name divideBy ist not appropriate for a function defined as:

f a b = a / b

It would be appropriate for a function defined as:

f a b = b / a
@willnwhite

This comment has been minimized.

Show comment
Hide comment
@willnwhite

willnwhite Jul 22, 2016

Thanks Janis, excellent.

willnwhite commented Jul 22, 2016

Thanks Janis, excellent.

@lukewestby lukewestby added the docs label Aug 20, 2016

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Sep 22, 2016

Member

I think this would benefit from an example, but I'd prefer to use one that showed up in normal usage. I think the division example does not clarify things very well. Let's start with uses and work from there to an example.

Member

evancz commented Sep 22, 2016

I think this would benefit from an example, but I'd prefer to use one that showed up in normal usage. I think the division example does not clarify things very well. Let's start with uses and work from there to an example.

@evancz evancz closed this Sep 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment