Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix error logging for non-browser environments. #69
Conversation
evancz
reviewed
Dec 29, 2014
| if (typeof document === 'undefined') { | ||
| console.log(e.message); | ||
| throw error; | ||
| if (typeof container.appendChild == 'undefined') { |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
pushed a commit
that referenced
this pull request
Dec 29, 2014
evancz
merged commit 0aaafb9
into
elm:master
Dec 29, 2014
1 check failed
continuous-integration/travis-ci
The Travis CI build failed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
laszlopandy
Dec 29, 2014
Contributor
Sorry, it should be triple equals.
On Monday, December 29, 2014, Evan Czaplicki notifications@github.com
wrote:
Merged #69 https://github.com/elm-lang/core/pull/69.
—
Reply to this email directly or view it on GitHub
https://github.com/elm-lang/core/pull/69#event-212397505.
|
Sorry, it should be triple equals. On Monday, December 29, 2014, Evan Czaplicki notifications@github.com
|
laszlopandy
deleted the
laszlopandy:error-log-fix
branch
Jan 5, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
laszlopandy commentedDec 29, 2014
Two things:
ewas changed toerrorbecauseedoesn't exist.appendChild, not a proxy (ifdocumentexists). Because it is possible that we are in an environment with adocumentbut still initialized byElm.worker, which gives{}forcontainer.