New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add uriEncode and uriDecode #702

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@lukewestby
Member

lukewestby commented Aug 28, 2016

These functions are available in evancz/elm-http but I believe they are more broadly useful - at least as useful as working with URLs in general. An example might be in combination with elm-lang/navigation and evancz/url-parser to deal with query strings. It would be great to be able to build things like query string parsers without including a dependency on evancz/elm-http.

Ordinarily this is a scenario where things would go in string-extra but since these require native calls I figured I'd start here.

@lukewestby lukewestby added the request label Aug 28, 2016

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Aug 28, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Aug 28, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

Luke Westby
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Aug 29, 2016

Member

These exist evancz/http like this.

I think a better move would be to move Http into core, and it is on my todo list, but I'd like to get 0.18 out before doing something like that.

Member

evancz commented Aug 29, 2016

These exist evancz/http like this.

I think a better move would be to move Http into core, and it is on my todo list, but I'd like to get 0.18 out before doing something like that.

@evancz evancz closed this Aug 29, 2016

@lukewestby

This comment has been minimized.

Show comment
Hide comment
@lukewestby

lukewestby Aug 29, 2016

Member

🤘 sounds like a great move to me. thanks!

Member

lukewestby commented Aug 29, 2016

🤘 sounds like a great move to me. thanks!

@evancz evancz deleted the luke/uri_encode_decode branch Sep 22, 2016

@nelsonic

This comment has been minimized.

Show comment
Hide comment
@nelsonic

nelsonic Oct 20, 2017

Hi! where do the uriEncode and uriDecode functions "live" now? (thanks!)

Edit: found them: http://package.elm-lang.org/packages/elm-lang/http/latest/Http#encodeUri

nelsonic commented Oct 20, 2017

Hi! where do the uriEncode and uriDecode functions "live" now? (thanks!)

Edit: found them: http://package.elm-lang.org/packages/elm-lang/http/latest/Http#encodeUri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment