New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added check for null process.root that arises when a process in the w… #706

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@johnnyhh

johnnyhh commented Sep 6, 2016

…orkQueue is killed.

If I call Process.kill on a process in the workQueue, the process's root is set to null, but it stays in the workQueue, leading to a runtime error in step() at the line var ctor = process.root.ctor. This bug pops up quite frequently in when I kill a process whose task (http request) has completed, but not yet been processed and removed from the workQueue.

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Sep 6, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Sep 6, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Sep 6, 2016

Member

You need to provide an http://sscce.org that uses elm-lang/core version 4.0.5. This issue should have been fixed in a much nicer way in that patch release.

If you can provide an http://sscce.org as an issue, we can then think about how to best fix the issue.

Member

evancz commented Sep 6, 2016

You need to provide an http://sscce.org that uses elm-lang/core version 4.0.5. This issue should have been fixed in a much nicer way in that patch release.

If you can provide an http://sscce.org as an issue, we can then think about how to best fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment