New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement List.map in pure elm #707

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@fredcy
Contributor

fredcy commented Sep 7, 2016

See discussion at https://groups.google.com/forum/#!topic/elm-dev/He_emRjsly8

The objective is to build a pure-Elm version of map that has good performance for shorter lists and avoids stack overflow for long lists.

There are benchmarks at https://github.com/fredcy/elm-core-benchmark.

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Sep 7, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Sep 7, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jul 8, 2017

Member

Based on your work, @Skinney created #872 which applied this technique to foldr and then implemented map in terms of that. He had some benchmarks that were pretty easy to run, so I played with those to tune the size vs speed.

Point is, map is implemented in Elm now through that! Sorry it took so long to get an answer on this, and thank you for the work! Turned out we could move a bunch of things into Elm with this!

Member

evancz commented Jul 8, 2017

Based on your work, @Skinney created #872 which applied this technique to foldr and then implemented map in terms of that. He had some benchmarks that were pretty easy to run, so I played with those to tune the size vs speed.

Point is, map is implemented in Elm now through that! Sorry it took so long to get an answer on this, and thank you for the work! Turned out we could move a bunch of things into Elm with this!

@evancz evancz closed this Jul 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment