New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for native file objects #718

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@dawehner

dawehner commented Sep 21, 2016

For some drag and drop support it would be nice if we could decode File objects natively.
This PR adds support for just, and really just that.

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Sep 21, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Sep 21, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@dawehner

This comment has been minimized.

Show comment
Hide comment
@dawehner

dawehner Sep 21, 2016

I like the process bot!

dawehner commented Sep 21, 2016

I like the process bot!

@OvermindDL1

Indentation is entirely incorrect based on the surrounding code, easy to fix. :-)

@dawehner

This comment has been minimized.

Show comment
Hide comment
@dawehner

dawehner Sep 21, 2016

Thank you for the review!
Oh these are actually tabs. I got quite confused when I looked at the git diffs earlier. I'll work on that.

dawehner commented Sep 21, 2016

Thank you for the review!
Oh these are actually tabs. I got quite confused when I looked at the git diffs earlier. I'll work on that.

@dawehner

This comment has been minimized.

Show comment
Hide comment
@dawehner

dawehner Sep 21, 2016

I hope this fixes the CS issues

dawehner commented Sep 21, 2016

I hope this fixes the CS issues

@lukewestby

This comment has been minimized.

Show comment
Hide comment
@lukewestby

lukewestby Sep 21, 2016

Member

Hey @dawehner!

Thanks for the contribution. So if you read the stuff that process bot shared or watch Evan's talk from Elm Conf you'll find that a better way to go about stuff like this is to jump into Slack or the Elm Discuss mailing list to find out if the thing you want to do is actually possible without changes given your use case. If it turns out that some change would be needed to do the thing you want it's best to discuss it on the Elm Dev mailing list before writing any code. It might turn out that your idea fits in well with some broader effort other folks are also interested in. Sound good?

Member

lukewestby commented Sep 21, 2016

Hey @dawehner!

Thanks for the contribution. So if you read the stuff that process bot shared or watch Evan's talk from Elm Conf you'll find that a better way to go about stuff like this is to jump into Slack or the Elm Discuss mailing list to find out if the thing you want to do is actually possible without changes given your use case. If it turns out that some change would be needed to do the thing you want it's best to discuss it on the Elm Dev mailing list before writing any code. It might turn out that your idea fits in well with some broader effort other folks are also interested in. Sound good?

@dawehner

This comment has been minimized.

Show comment
Hide comment
@dawehner

dawehner Sep 22, 2016

It does. In general though it was a fun journey through elm, seeing that its just JS at the end of the day (yeah I'm Mr. obvious ;) )

I'm hanging out in #elm-dev now

dawehner commented Sep 22, 2016

It does. In general though it was a fun journey through elm, seeing that its just JS at the end of the day (yeah I'm Mr. obvious ;) )

I'm hanging out in #elm-dev now

@lukewestby

This comment has been minimized.

Show comment
Hide comment
@lukewestby

lukewestby Sep 22, 2016

Member

Great! I'm gonna close this now but it'll still be here to reopen if it turns out this was the code we needed all along. Thanks!

Member

lukewestby commented Sep 22, 2016

Great! I'm gonna close this now but it'll still be here to reopen if it turns out this was the code we needed all along. Thanks!

@lukewestby lukewestby closed this Sep 22, 2016

@dawehner

This comment has been minimized.

Show comment
Hide comment
@dawehner

dawehner Sep 22, 2016

@lukewestby Can you give me any pointer of an existing issue around that kind of problem space?

dawehner commented Sep 22, 2016

@lukewestby Can you give me any pointer of an existing issue around that kind of problem space?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment