Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for native file objects #718
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Sep 21, 2016
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Sep 21, 2016
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dawehner
commented
Sep 21, 2016
|
I like the process bot! |
OvermindDL1
suggested changes
Sep 21, 2016
Indentation is entirely incorrect based on the surrounding code, easy to fix. :-)
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dawehner
Sep 21, 2016
Thank you for the review!
Oh these are actually tabs. I got quite confused when I looked at the git diffs earlier. I'll work on that.
dawehner
commented
Sep 21, 2016
|
Thank you for the review! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dawehner
commented
Sep 21, 2016
|
I hope this fixes the CS issues |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
lukewestby
Sep 21, 2016
Member
Hey @dawehner!
Thanks for the contribution. So if you read the stuff that process bot shared or watch Evan's talk from Elm Conf you'll find that a better way to go about stuff like this is to jump into Slack or the Elm Discuss mailing list to find out if the thing you want to do is actually possible without changes given your use case. If it turns out that some change would be needed to do the thing you want it's best to discuss it on the Elm Dev mailing list before writing any code. It might turn out that your idea fits in well with some broader effort other folks are also interested in. Sound good?
|
Hey @dawehner! Thanks for the contribution. So if you read the stuff that process bot shared or watch Evan's talk from Elm Conf you'll find that a better way to go about stuff like this is to jump into Slack or the Elm Discuss mailing list to find out if the thing you want to do is actually possible without changes given your use case. If it turns out that some change would be needed to do the thing you want it's best to discuss it on the Elm Dev mailing list before writing any code. It might turn out that your idea fits in well with some broader effort other folks are also interested in. Sound good? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dawehner
Sep 22, 2016
It does. In general though it was a fun journey through elm, seeing that its just JS at the end of the day (yeah I'm Mr. obvious ;) )
I'm hanging out in #elm-dev now
dawehner
commented
Sep 22, 2016
|
It does. In general though it was a fun journey through elm, seeing that its just JS at the end of the day (yeah I'm Mr. obvious ;) ) I'm hanging out in #elm-dev now |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
lukewestby
Sep 22, 2016
Member
Great! I'm gonna close this now but it'll still be here to reopen if it turns out this was the code we needed all along. Thanks!
|
Great! I'm gonna close this now but it'll still be here to reopen if it turns out this was the code we needed all along. Thanks! |
lukewestby
closed this
Sep 22, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dawehner
Sep 22, 2016
@lukewestby Can you give me any pointer of an existing issue around that kind of problem space?
dawehner
commented
Sep 22, 2016
|
@lukewestby Can you give me any pointer of an existing issue around that kind of problem space? |
dawehner commentedSep 21, 2016
For some drag and drop support it would be nice if we could decode File objects natively.
This PR adds support for just, and really just that.