New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help explain purpose of ! #719

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@willnwhite

willnwhite commented Sep 22, 2016

No description provided.

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Sep 22, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Sep 22, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@willnwhite willnwhite referenced this pull request Sep 22, 2016

Open

Explain ! #51

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Sep 23, 2016

Contributor

There is #678.

Contributor

jvoigtlaender commented Sep 23, 2016

There is #678.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Oct 2, 2016

Contributor

@willnwhite, any comment on the redundancy of your PR due to the older one I linked to?

Contributor

jvoigtlaender commented Oct 2, 2016

@willnwhite, any comment on the redundancy of your PR due to the older one I linked to?

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Oct 3, 2016

Member

@jvoigtlaender, curating issues and PRs is better done by maintainers, not folks who open stuff. I think the other one is too verbose, and I think this one may need some extra info. The right move is probably to just remove (!) entirely.

I don't know if you saw this talk I did recently, but one of the points I try to make is that it's fine to let stuff like this sit for a while. It looks like a PR, but it's really a report that (!) is kind of confusing.

Member

evancz commented Oct 3, 2016

@jvoigtlaender, curating issues and PRs is better done by maintainers, not folks who open stuff. I think the other one is too verbose, and I think this one may need some extra info. The right move is probably to just remove (!) entirely.

I don't know if you saw this talk I did recently, but one of the points I try to make is that it's fine to let stuff like this sit for a while. It looks like a PR, but it's really a report that (!) is kind of confusing.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Oct 4, 2016

Contributor

Particularly as a report rather than PR it seems a duplicate of that other one. But good to know how you want to handle this.

Contributor

jvoigtlaender commented Oct 4, 2016

Particularly as a report rather than PR it seems a duplicate of that other one. But good to know how you want to handle this.

@willnwhite

This comment has been minimized.

Show comment
Hide comment
@willnwhite

willnwhite Oct 4, 2016

I've read #678 and added some more info to this PR. I hope this could help newcomers, at least before any removal of (!) occurs.

willnwhite commented Oct 4, 2016

I've read #678 and added some more info to this PR. I hope this could help newcomers, at least before any removal of (!) occurs.

@jvoigtlaender jvoigtlaender added the docs label Oct 12, 2016

@bukzor

This comment has been minimized.

Show comment
Hide comment
@bukzor

bukzor Oct 25, 2016

+1 to remove (!)

bukzor commented Oct 25, 2016

+1 to remove (!)

@Pilatch

Awesome. I was wondering what the heck this did.

@Pilatch

This comment has been minimized.

Show comment
Hide comment
@Pilatch

Pilatch Dec 15, 2016

@evancz I hear that ! is confusing, and that's a reason to remove it, but until it's removed, it would be a shame to not clear up that confusion for newcomers to the language.

Pilatch commented Dec 15, 2016

@evancz I hear that ! is confusing, and that's a reason to remove it, but until it's removed, it would be a shame to not clear up that confusion for newcomers to the language.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jul 8, 2017

Member

The current plan is to drop this operator for the next release. If that does not happen, I will add it back with documentation.

Member

evancz commented Jul 8, 2017

The current plan is to drop this operator for the next release. If that does not happen, I will add it back with documentation.

@evancz evancz closed this Jul 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment