Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upHelp explain purpose of ! #719
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Sep 22, 2016
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Sep 22, 2016
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
There is #678. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Oct 2, 2016
Contributor
@willnwhite, any comment on the redundancy of your PR due to the older one I linked to?
|
@willnwhite, any comment on the redundancy of your PR due to the older one I linked to? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Oct 3, 2016
Member
@jvoigtlaender, curating issues and PRs is better done by maintainers, not folks who open stuff. I think the other one is too verbose, and I think this one may need some extra info. The right move is probably to just remove (!) entirely.
I don't know if you saw this talk I did recently, but one of the points I try to make is that it's fine to let stuff like this sit for a while. It looks like a PR, but it's really a report that (!) is kind of confusing.
|
@jvoigtlaender, curating issues and PRs is better done by maintainers, not folks who open stuff. I think the other one is too verbose, and I think this one may need some extra info. The right move is probably to just remove I don't know if you saw this talk I did recently, but one of the points I try to make is that it's fine to let stuff like this sit for a while. It looks like a PR, but it's really a report that |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Oct 4, 2016
Contributor
Particularly as a report rather than PR it seems a duplicate of that other one. But good to know how you want to handle this.
|
Particularly as a report rather than PR it seems a duplicate of that other one. But good to know how you want to handle this. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
willnwhite
Oct 4, 2016
I've read #678 and added some more info to this PR. I hope this could help newcomers, at least before any removal of (!) occurs.
willnwhite
commented
Oct 4, 2016
•
|
I've read #678 and added some more info to this PR. I hope this could help newcomers, at least before any removal of |
jvoigtlaender
added
the
docs
label
Oct 12, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bukzor
commented
Oct 25, 2016
|
+1 to remove (!) |
Pilatch
approved these changes
Dec 15, 2016
Awesome. I was wondering what the heck this did.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Pilatch
Dec 15, 2016
@evancz I hear that ! is confusing, and that's a reason to remove it, but until it's removed, it would be a shame to not clear up that confusion for newcomers to the language.
Pilatch
commented
Dec 15, 2016
|
@evancz I hear that |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Jul 8, 2017
Member
The current plan is to drop this operator for the next release. If that does not happen, I will add it back with documentation.
|
The current plan is to drop this operator for the next release. If that does not happen, I will add it back with documentation. |
willnwhite commentedSep 22, 2016
No description provided.