/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset `lastIndex` in `Regex.split` so that it is idempotent. #737

Merged
merged 1 commit into from Oct 24, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rgrempel @process-bot @evancz
@rgrempel
Contributor

rgrempel commented Oct 22, 2016

Fixes #482.
@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Oct 22, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Oct 22, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@evancz evancz merged commit 8023083 into elm:master Oct 24, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Oct 24, 2016

Member

Great, thank you!
Member

evancz commented Oct 24, 2016

Great, thank you!

@rgrempel rgrempel deleted the rgrempel:regex-split branch Oct 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment