Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove examples that used the old range syntax #759
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Nov 24, 2016
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Nov 24, 2016
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
jvoigtlaender
added
the
docs
label
Nov 25, 2016
Pilatch
approved these changes
Dec 15, 2016
Looks good to me. You can probably just close and re-open the pull request to kick Travis into testing it again.
ryantriangles
closed this
Dec 18, 2016
ryantriangles
reopened this
Dec 18, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Dec 22, 2016
Member
Ah, I made these changes as well before seeing this. Thanks for pointing this out though!
|
Ah, I made these changes as well before seeing this. Thanks for pointing this out though! |
ryantriangles commentedNov 24, 2016
If the range literal syntax has been removed from the language, then it ought to be removed from documentation examples too -- and I think a simple
[1,2,3,4,5]is nicer and clearer than(List.range 1 5), even if it's pretty obvious what the latter does without looking.