/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native Array.toIndexedList implementation. #780

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@Pilatch Pilatch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@efarrer @process-bot @mgold @evancz @Pilatch
@efarrer

efarrer commented Dec 10, 2016

Resolve a TODO for Array.toIndexedList by creating a native implementation of the function.

No change in behavior.
@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Dec 10, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Dec 10, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.
@mgold

This comment has been minimized.

Show comment
Hide comment
@mgold

mgold Dec 10, 2016

Contributor

This is available in Array.Hamt
Contributor

mgold commented Dec 10, 2016

This is available in Array.Hamt
src/Native/Array.js
function toIndexedList_(list, a)
{
for (var i = a.table.length - 1; i >= 0; i--)

This comment has been minimized.

Show comment
Hide comment
@Pilatch

Pilatch Dec 15, 2016

!== -1 is slightly faster than >= 0
Copy URL
@Pilatch

Pilatch Dec 15, 2016

!== -1 is slightly faster than >= 0

This comment has been minimized.

Show comment
Hide comment
@Pilatch

Pilatch Dec 15, 2016

... and ~i may be faster still.
Copy URL
@Pilatch

Pilatch Dec 15, 2016

... and ~i may be faster still.
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Mar 26, 2017

Member

Rather not add stuff to Array since the existing implementation is going to be phased out.
Member

evancz commented Mar 26, 2017

Rather not add stuff to Array since the existing implementation is going to be phased out.

@evancz evancz closed this Mar 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment