Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdding Unit Tests for Maybe #784
Conversation
FRosner
added some commits
Dec 15, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
process-bot
Dec 15, 2016
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Dec 15, 2016
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Thanks @FRosner! |
rtfeldman
merged commit 9e43ee9
into
elm:master
Dec 18, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
FRosner commentedDec 15, 2016
Problem
There are no unit tests for the public functions of the
Maybemodule. This makes it impossible to apply refactoring to the existing code without knowing whether this will break the expected behaviour.Also, unit tests are good examples on how to use an API. All public functions should have unit tests.
Solution
Add unit tests.