New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Unit Tests for Maybe #784

Merged
merged 2 commits into from Dec 18, 2016

Conversation

Projects
None yet
3 participants
@FRosner
Contributor

FRosner commented Dec 15, 2016

Problem

There are no unit tests for the public functions of the Maybe module. This makes it impossible to apply refactoring to the existing code without knowing whether this will break the expected behaviour.

Also, unit tests are good examples on how to use an API. All public functions should have unit tests.

Solution

Add unit tests.

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Dec 15, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Dec 15, 2016

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@rtfeldman

This comment has been minimized.

Show comment
Hide comment
@rtfeldman
Member

rtfeldman commented Dec 18, 2016

Thanks @FRosner!

@rtfeldman rtfeldman merged commit 9e43ee9 into elm:master Dec 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment