Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMore tests #785
Conversation
rtfeldman
added some commits
Dec 18, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Dec 18, 2016
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Dec 18, 2016
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
rtfeldman
merged commit 1642a4d
into
master
Dec 18, 2016
rtfeldman
deleted the
more-tests
branch
Dec 18, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Dec 18, 2016
Member
I think putting them in https://github.com/elm-lang/elm-compiler/tree/master/tests/test-files/good or https://github.com/elm-lang/elm-compiler/tree/master/tests/test-files/bad would be better. There is already infrastructure that is specifically about detecting code gen changes and making sure certain things parse or fail.
|
I think putting them in https://github.com/elm-lang/elm-compiler/tree/master/tests/test-files/good or https://github.com/elm-lang/elm-compiler/tree/master/tests/test-files/bad would be better. There is already infrastructure that is specifically about detecting code gen changes and making sure certain things parse or fail. |
rtfeldman commentedDec 18, 2016
•
edited
Edited 1 time
-
rtfeldman
edited Dec 18, 2016 (most recent)
Add some more tests which also serve as regression tests for parser bugs.