Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix disappearing HTML elements, Fixes #862 #79
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
evancz
Jan 6, 2015
Member
Reading the code and knowing what my intent was with that code, I am pretty sure this is just a bug. I have not touched this code in ages, so it is somewhat mysterious if this arose with 0.14. In any case, this looks good to me!
Thank you so much for figuring this out, I really really appreciate it!
|
Reading the code and knowing what my intent was with that code, I am pretty sure this is just a bug. I have not touched this code in ages, so it is somewhat mysterious if this arose with 0.14. In any case, this looks good to me! Thank you so much for figuring this out, I really really appreciate it! |
pushed a commit
that referenced
this pull request
Jan 6, 2015
evancz
merged commit de5d8e0
into
elm:master
Jan 6, 2015
1 check passed
continuous-integration/travis-ci
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jwmerrill commentedJan 5, 2015
See discussion on #862, especially elm/compiler#862 (comment).
This merits careful review because I don't know why the
kid.getContextcheck that I'm removing was there in the first place. @etaque reports that this change fixes the issue.