Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unused imports #798
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Dec 30, 2016
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Dec 30, 2016
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mgold
Dec 30, 2016
Contributor
|
|
jvoigtlaender
closed this
Dec 30, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nicolaiskogheim
commented
Dec 31, 2016
|
@mgold But you're not sure? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
No, I'm not positive. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Dec 31, 2016
Contributor
Actually, @mgold is right that default import rules do not apply to the core library. At the same time, this does not matter for this PR, since the imports removed are truly unused in the respective files.
|
Actually, @mgold is right that default import rules do not apply to the core library. At the same time, this does not matter for this PR, since the imports removed are truly unused in the respective files. |
jvoigtlaender
reopened this
Dec 31, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Mar 7, 2018
Member
There is no harm in having extra imports. In the development build, only the top-level declarations that are needed are included, so it does not matter about imports for that. It can lengthen compile time, but the dev build also caches all packages, so they are only built once. That means there is no perf difference ever. So I think it is easier to just keep things as is. It's not hurting anything, and it'll take longer to rollback if something is off.
|
There is no harm in having extra imports. In the development build, only the top-level declarations that are needed are included, so it does not matter about |
gabrielelana commentedDec 30, 2016
No description provided.