Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #819 #820
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Jan 23, 2017
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Jan 23, 2017
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
evancz
merged commit 0e732e7
into
master
Jan 23, 2017
evancz
deleted the
fix_819
branch
Jan 23, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Jan 23, 2017
Member
Thanks for the quick fix @lukewestby! This is released as 5.1.1 now. Sorry to folk who ran into this!
|
Thanks for the quick fix @lukewestby! This is released as 5.1.1 now. Sorry to folk who ran into this! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
lukewestby
commented
Jan 23, 2017
•
edited
Edited 1 time
-
lukewestby
edited Jan 23, 2017 (most recent)
edited
-
Jan 23, 2017 (most recent)
|
|
lukewestby commentedJan 23, 2017
•
edited
Edited 1 time
-
lukewestby
edited Jan 23, 2017 (most recent)
If the result value is extracted and guarded by a throw in
sendthen the value should be passed directly topostInitSend.I think it would be good to set up some fixtures that can run in a separate node.js test suite to verify that ports are working okay to avoid regressions like this in the future, but that's a discussion for the ML.
#819