[failing] add tests for equality of Json.Encode.Value

[soenkehahn]

Equality (elm's ==) is not commutative for Json.Encode.Values created with object. I believe this is a bug. This PR adds failing test cases but not a fix.

[process-bot]

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

[process-bot]

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

[evancz]

To restrict equality to only work on sensible values, it requires changes in the compiler. Those changes are pretty involved, and the problem is known. Overall, I do not think having a failing test will bring us closer to the fix, and it will make other things harder in the meantime.

[evancz]

To restrict equality to only work on sensible values, it requires changes in the compiler. Those changes are pretty involved, and the problem is known. Overall, I do not think having a failing test will bring us closer to the fix, and it will make other things harder in the meantime.

[soenkehahn]

Sorry, this was not meant to be merged as is, only to provide a very concrete bug report. (Therefore it's completely fair to close this PR.)

Those changes are pretty involved, and the problem is known.

Is this problem tracked somewhere? Could you point me to it, please?

[soenkehahn]

Sorry, this was not meant to be merged as is, only to provide a very concrete bug report. (Therefore it's completely fair to close this PR.)

Those changes are pretty involved, and the problem is known.

Is this problem tracked somewhere? Could you point me to it, please?

[evancz]

There's not a public issue. The path is not "4 clear steps" that just have to be implemented by anyone, so I don't think having it tracked on GitHub really helps fix things. Design choices need to be made, making those choices needs to be high priority, they need to fit with a release, etc. So it's at a point where I feel that public comment does not help with any specific piece of work, and accepting public comment may make things slower and take people's time for no particular reason.

[evancz]

There's not a public issue. The path is not "4 clear steps" that just have to be implemented by anyone, so I don't think having it tracked on GitHub really helps fix things. Design choices need to be made, making those choices needs to be high priority, they need to fit with a release, etc. So it's at a point where I feel that public comment does not help with any specific piece of work, and accepting public comment may make things slower and take people's time for no particular reason.

[soenkehahn]

Sounds good, thanks!

[soenkehahn]

Sounds good, thanks!