Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd tests for Set #838
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
process-bot
Feb 11, 2017
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Feb 11, 2017
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Lovely, thank you @j-panasiuk! |
rtfeldman
merged commit 29b82e3
into
elm:master
Apr 21, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
j-panasiuk commentedFeb 11, 2017
Unit tests for each function exposed by Set module
If you feel there is too much redundancy in the tests, please let me know and I will trim them a bit.
(on the other hand I feel that many of these should be fuzz tests, but I didn't see fuzz testing used anywhere else in core, so decided to stick with unit testing for now)